googlefonts / googlefonts/gftools

[Buidler] temp files are deleted even when error during build

Open
#728 2 comments 0 reactions 1 assignee Claimed by @eliheuer View on GitHub
bug builder
Dominant language
Python
Stars
283
Forks
73
Avg merge
21h 25m
Merged PRs (30d)
8

Description

- The directories master_ufo and instance_ufo should not be deleted if the font doesn't build
- There should not be "Done building fonts!" if the build fails

```
fontmake: Error: In 'instance_ufo/Borel-Regular.ufo': Compiling UFO failed: instance_ufo/Borel-Regular.ufo/features.fea:126:2: Expected a glyph class with 109 elements after "by", but found a glyph class with 110 elements
ninja: build stopped: subcommand failed.
Removed file: /Users/rosalie/Google/CursiveCP/Borel/sources/build.ninja
Removed file: /Users/rosalie/Google/CursiveCP/Borel/sources/.ninja_log
Removed directory: /Users/rosalie/Google/CursiveCP/Borel/sources/master_ufo
Removed directory: /Users/rosalie/Google/CursiveCP/Borel/sources/instance_ufo
Done building fonts!
```

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.