googlefonts / googlefonts/gftools

gftools-fix-fsselection.py autofix might not work, santity-check definitely broken

Open
#48 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
Python
Stars
283
Forks
73
Avg merge
21h 25m
Merged PRs (30d)
8

Description

```sh
$ cd ~/src/github.com/davelab6/tools/bin

$ ./gftools-fix-fsselection.py ~/fonts/ofl/nanumgothic/NanumGothic-ExtraBold.ttf
| filename | fsSelection |
|:--------------------------|:------------------|
| NanumGothic-ExtraBold.ttf | 00000000 11000000 |

dcrossland@dcrossland-ubi2:~/src/github.com/davelab6/tools/bin$ ./gftools-fix-fsselection.py ~/fonts/ofl/nanumgothic/NanumGothic-ExtraBold.ttf --autofix
| filename | fsSelection |
|:------------------------------|:------------------|
| NanumGothic-ExtraBold.ttf.fix | 00000000 01000000 |

$ mv ~/fonts/ofl/nanumgothic/NanumGothic-ExtraBold.ttf.fix ~/fonts/ofl/nanumgothic/NanumGothic-ExtraBold.ttf

```

This resulted in https://github.com/google/fonts/commit/245b697e303885b8b8373d75459623eee23259fb

However, the onboarding checks run within the Google Fonts engineering team still reject these fonts, and I can't reproduce because:

```
$ python ./gftools-sanity-check.py ~/fonts/ofl/nanummyeongjo/NanumMyeongjo-Bold.ttf
Traceback (most recent call last):
File "./gftools-sanity-check.py", line 29, in
from gftools.util import google_fonts as fonts
ImportError: No module named util
```

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.