googlefonts / googlefonts/gftools

Builder should Error when font name in config doesn't match glyphs file

Open
#387 0 comments 0 reactions 1 assignee Claimed by @m4rc1e View on GitHub
builder
Dominant language
Python
Stars
283
Forks
73
Avg merge
21h 25m
Merged PRs (30d)
8

Description

In converting Museo Moderno to the UFR format, I ran into an issue where the variable font was not generating instances in the `fvar` table. It turned out that the issue was that there was a slight mismatch between the font name in the `config.yaml` file ("Museo Moderno") and the name in the Glyphs file itself ("MuseoModerno").

I think that it would make sense to issue an error if there is mismatch between these two locations rather than building the font and silently failing to produce an `fvar` table.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.