googlefonts / googlefonts/gftools

Gf-Bot not detecting static/ folder in PR while local fontbakery does detect it

Open
#174 3 comments 0 reactions 0 assignees View on GitHub
Dominant language
Python
Stars
283
Forks
73
Avg merge
21h 25m
Merged PRs (30d)
8

Description

Moved from https://github.com/googlefonts/fontbakery/issues/2738

# Observed behaviour

At google/fonts#1908 (comment), the gf-bot is including a fail that I believe is invalid. My changed files include a static folder with static fonts, but I am still getting this flagged:

```
🔥 FAIL: A static fonts directory with at least two fonts must accompany variable fonts

com.google.fonts/check/repo/vf_has_static_fonts

--- Rationale ---

Variable font family directories kept in the google/fonts git repo must include
a static/ subdir containing static fonts.
These files are meant to be served for users that still lack support for
variable fonts in their web browsers.
```

Here's the specific commit:

google/fonts@ba8c4ed

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.