googlefonts / googlefonts/gftools

add-font adds spaces to ABeeZee font name

Open
#122 7 comments 0 reactions 0 assignees View on GitHub
Dominant language
Python
Stars
283
Forks
73
Avg merge
21h 25m
Merged PRs (30d)
8

Description

I'm using `add-fonts` to generate new metadata for all families in google/fonts, in order to make sure we don't exclude latin-ext glyphs where they exist (see https://github.com/google/fonts/issues/187). This has led me to find a number of issues with `add-font`. I'll document them separately, so that we can hopefully correct things that are real issues, and I can be better informed if some of them aren't real issues.

---

If `add-font` is run on ABeeZee, the `METADATA.pb` file ends up with

```
name: "A Bee Zee"
```

However, in the `name` table of ABeeZee, `nameID` 1 is

```

ABeeZee

```

(without spaces)

So, we may need to add an exception for ABeeZee, unless this is really the intended behavior.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.