googlefonts / googlefonts/gftools

gen-stat default axis order maybe wrong + issue with non elided style

Open
#1,128 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Python
Stars
283
Forks
73
Avg merge
21h 25m
Merged PRs (30d)
8

Description

I am creating a bunch of subfamilies (sliced at different width) for [Zalando](https://github.com/zalando/sans) with builder 2. I thought I could `post-process: buildStat` but I found 1 or maybe 2 mistakes.

- Axis order gets wrong:
GF expects `wdth` to be before `wght`. But it gets in second place by default.

- It is debatable to include the wdth axis in this case:
Since the VF gets sliced at a certain width location, and so the width axis is dropped, it could be expected to also drop it in the STAT able. I understand why it is there though and I support it. It creates a problem in MS Words (this one again) because it takes the family name + location in fvar + name in STAT ending up in: `Zalando Sans SemiExpanded SemiExpanded SemiBold`

I understand that GF doesn't want to cater to MS Word's bugs and therefore not drop the wdth axis in this case. A simple workaround, which would be imo more correct in general would be to **elide the unique style name in the width axis** since you find it in the family name already.

In any case I gonna patch a custom STAT table now but wanted to let you know.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.