googlefonts / googlefonts/gftools

gftools-rename-font does not rename instance PS names

Open
#1,060 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Python
Stars
283
Forks
73
Avg merge
21h 25m
Merged PRs (30d)
8

Description

`gftools-rename-font` (which uses the axisregistry `build_name_table` function to do its work) claims to change "the PostScript name" - which it does, partially. However, any `fvar` table instance PS names are not renamed:

```
$ gftools-rename-font --just-family -o PPS-Deva.ttf fonts-builder/variable/PlaypenSans\[wght\].ttf "Playpen Sans Deva" --just-family
Saving font: PPS-Deva.ttf
$ ttx -o - -t name PPS-Deva.ttf | grep 'PlaypenSans-'
Dumping "PPS-Deva.ttf" to ""...
Dumping 'name' table...
PlaypenSans-Thin
PlaypenSans-ExtraLight
PlaypenSans-Light
PlaypenSans-Regular
PlaypenSans-Medium
PlaypenSans-SemiBold
PlaypenSans-Bold
PlaypenSans-ExtraBold
```

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.