googlefonts / googlefonts/gf-glyphs-scripts

Copyright notice check has incorrect assumption about date

Open
#62 1 comment 0 reactions 1 assignee View on GitHub

@m4rc1e is already working on this.

Since Jun 29, 2020.

Dominant language
Python
Stars
21
Forks
9
No merged PRs in 30d

Description

https://github.com/googlefonts/gf-glyphs-scripts/blob/f93799f2ee67c30b442ded873a76b71341057a23/Google%20Fonts/qa.py#L192-L208

This check is wrong, the copyright date should be the earliest date that the project started, not the current date. There is likely no way to check that date programmatically, so a regex that checks for 4 digits making the year is sufficient (likely started 19 or 20 :)

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.