googlefonts / googlefonts/gf-glyphs-scripts

Copyright string check is a Grammar Na..i

Open
#23 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
21
Forks
9
PR merge metrics
No merged PRs in 30d

Description

Font:
Copyright 2015 The Amatic SC Project Authors (https://github.com/googlefonts/AmaticSC)

OFL:
Copyright 2015 The Amatic SC Project Authors (https://github.com/googlefonts/AmaticSC)

QA spits out:

Copyright string is incorrect.

It must contain or be:
Copyright 2017 The Amatic SC Project Authors (https://github.com/googlefonts/AmaticSC.git)

If the family has a RFN:
Copyright 2017 The Amatic SC Project Authors (https://github.com/googlefonts/AmaticSC.git), with Reserved Font Name "Amatic SC".

I think keeping earliest mention year is fine, no?

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the Python QA check that reports the copyright-string error and inspect how it compares the year, repository URL, and Reserved Font Name text. Confirm whether retaining the earliest copyright year is intended, then add or update coverage for that behavior and verify the Amatic SC case passes.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
testing
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.