googlefonts / googlefonts/fontmake
Invalid syntax when classes contain a final glyph that is commented out
- Dominant language
- Python
- Stars
- 888
- Forks
- 97
- Avg merge
- 4d 52m
- Merged PRs (30d)
- 1
Description
Sometimes we may have a glyph class that contains a commented-out glyph as its final member, like so:
In this case, the glyph is not present in the font yet, so the glyph name is present, but commented out, to remind me to add it to the **@w2_5** class once it's there.
However, when FontMake parses it, it can't find the **@w3** class. Why is this? I had a look at the UFO FontMake had built, and look what happened:
The closing ] from @w2_5 accidentally got commented out, not just the glyph name! So then it's presumably not parsing the @w3 as a new class name, but as a member of the @w2_5 class?
At any rate, FontMake throws this error when trying to build the variable font:
Contributor guide
Assessment
This issue has not been assessed yet.