googlefonts / googlefonts/fontmake

Supporting unicode characters in glyph names

Open
#683 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Python
Stars
888
Forks
97
Avg merge
4d 52m
Merged PRs (30d)
1

Description

What do you think about supporting glyph names with unicode characters? UFO allows this, but not AFDKO feature file format. Since fontmake creates final production names I think supporting this would help a lot with naming glyphs and producing fonts especially for non-latin fonts. Here is a test UFO I made which throws this error:
[unicode-glyph-name-test.ufo.zip](https://github.com/googlefonts/fontmake/files/4953360/unicode-glyph-name-test.ufo.zip)
```
INFO:fontmake.font_project:Building OTF for test-Regular
INFO:ufo2ft:Pre-processing glyphs
INFO:ufo2ft.filters:Running DecomposeComponentsFilter on test-Regular
INFO:ufo2ft.filters:Running RemoveOverlapsFilter on test-Regular
INFO:ufo2ft:Building OpenType tables
fontmake: Error: In 'test.ufo': Compiling UFO failed: 'latin-1' codec can't encode character '\u0628' in position 0: ordinal not in range(256)
```
I guess this also means that fonttools feature file parser needs to be modified to support these characters. I would be very much interested to make this work if you think this is useful.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.