googlefonts / googlefonts/fontmake

Feature file path resolving fails when slash included in source UFO path

Open
#604 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Python
Stars
888
Forks
97
Avg merge
4d 52m
Merged PRs (30d)
1

Description

```
> fontmake -u .\sources\NotoSansSyriacEstrangela_Thin.ufo\ -o ttf
[...]
fontTools.feaLib.error.IncludedFeaNotFound: .\sources\NotoSansSyriacEstrangela_Thin.ufo\:1:8: Estrangela_GSUB.fea
```

Removing the `\` at the end of `.\sources\NotoSansSyriacEstrangela_Thin.ufo\` makes it work. Maybe a os.path.resolve is needed on the source path before feature file paths are computed.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.