googlefonts / googlefonts/fontmake

should decompose components with different 2x2 transforms when building VF

Open
#595 12 comments 0 reactions 0 assignees View on GitHub
Dominant language
Python
Stars
888
Forks
97
Avg merge
4d 52m
Merged PRs (30d)
1

Description

Example: the /Otildeacute glyph in the Black **named instance** doesn't match the same glyph in the Black **UFO master** when it uses a nested component. But when the nested component (tildecomb_acutecomb.case) is decomposed, the glyph in the var font matches what's in the master. This seems like a bug. (screenshots below for reference)

As a designer it's better to keep the sources with high level information (ie /tildecomb_acutecomb.case is made up of /tildecomb and /acutecomb.case). And I would expect that a Black named instance in the var font should match the static font generated from that Black UFO master, especially when there is only one axis and only two masters.

I understand that components can't be nested in the final font. But it seems that fontmake could do a better job of decomposing the nested component on generate so the named instance matches the master and we can leave the sources as is for future editing. Thanks! (the example here is from the Alegreya project for @davelab6 and @m4rc1e )

![UFO_master](https://user-images.githubusercontent.com/3900241/68880464-514ea580-06d9-11ea-89e9-c4e7c53e9b41.png)
![fontmake_compare](https://user-images.githubusercontent.com/3900241/68880474-54e22c80-06d9-11ea-8f2f-5fdb0f826476.png)

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.