googlefonts / googlefonts/fontmake

fvar should not be constructed from all .glyphs instances if a familyName customParam is defined

Open
#437 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
Python
Stars
888
Forks
97
Avg merge
4d 52m
Merged PRs (30d)
1

Description

In [Vollkorn](https://github.com/FAlthausen/Vollkorn-Typeface), there's a sibling SC family constructed in the following manner.

![screen shot 2018-05-31 at 19 30 38](https://user-images.githubusercontent.com/7525512/40800749-249d4ae6-6509-11e8-987c-cda8fecaffca.png)

When I generate a variable font with `fontmake -g font.glyphs -o variable`, I get the following fvar table:
```



wght
400.0
400.0
900.0
256






































```

When I delete the SC instances, I get the following correct table
```



wght
400.0
400.0
900.0
256




















```

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.