googlefonts / googlefonts/fontmake

feature files missing in newest fontmake

Open
#1,096 7 comments 0 reactions 0 assignees View on GitHub
Dominant language
Python
Stars
888
Forks
97
Avg merge
4d 52m
Merged PRs (30d)
1

Description

Just hit this error when building with the latest fontmake 3.9.0
`Compiling UFO failed: :1:8: The following feature file should be included but cannot be found: ../fea/MyFeatures.fea`

I'm not sure where this got broken, but in previous versions this was not an issue. FWIW, my .ufo files are in a folder called `1-drawing` and my feature file: `MyFeatures.fea `is in a parallel folder called `fea`, and in each .ufo file I have `include(../fea/MyFeatures.fea);` Not sure if it matters, but my designspace file `myTypeface.designspace` is in another parallel folder called `designspace`. All of these folder (`1-drawing`, `fea`, and `designspace`) are in the same enclosing folder. So I can't figure out where fontmake is expecting the features to be located now.

If I generate from RoboFont, my features are included without issue. Same when I preview my features using the FeaturePreview extension. I would expect fontmake to match this behavior.

This used to work in fontmake 2x, I'm not sure where this changed. This is a bug, right?

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.