googlefonts / googlefonts/fontmake
Outline incompatibilities introduced later in the pipeline are not fatal
- Dominant language
- Python
- Stars
- 888
- Forks
- 97
- Avg merge
- 4d 52m
- Merged PRs (30d)
- 1
Description
Earlier we encountered #897 as cu2qu raised a fatal error, however, when debugging the issue we tested with and without cu2qu and noticed that when cu2qu is disabled then the font build completes with an incomplete `gvar` table.
This happens as varLib skips glyphs with incompatible outlines [with a warning but not a fatal error](https://github.com/fonttools/fonttools/blob/2ce45c2861cd274a265f68a3fdb6b60902c42892/Lib/fontTools/varLib/__init__.py#L334); the compatibility checker is run at the beginning of the pipeline and so also cannot detect such issues.
For projects with quadratic sources it would be nice to disable cu2qu but keep the same level of strictness. Should we make the above warning fatal by default (perhaps only for fontmake)?
Contributor guide
Assessment
This issue has not been assessed yet.