googlefonts / googlefonts/fontc

Why panic when you can Result

Open
#84 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Rust
Stars
193
Forks
21
Avg merge
1d 20h
Merged PRs (30d)
60

Description

As https://github.com/googlefonts/fontmake-rs/pull/79/files/8c03ae050bb29a9552c94a7d0cb9b165600ab668#r1066299668 suggests, we have accumulated a number of panic or known to be fallible unwrap cases we probably want to make into errors.

"probably" because panic has one really nice characteristic: you get a useful callstack. Tracking down problems from errors seems to be less convenient. Perhaps that means error should https://doc.rust-lang.org/std/backtrace/struct.Backtrace.html#method.capture?

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.