googlefonts / googlefonts/fontc

FeaMerge errors could be more useful

Open
#2,142 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Rust
Stars
193
Forks
21
Avg merge
1d 20h
Merged PRs (30d)
60

Description

Came up during review, but I'm going to defer for now; the short version is that it would be nice if our merge errors could name masters or provide paths to the relevant files, instead of using fairly meaningless indices as identifiers.

the master index in MergeError is the position after this swap, so when the merge fails the user gets "master 3: ..." and no way to tell which features.fea that is. fontbe knows the path and location of each master at this point; can we map the index back to the source, or attach them here, before this reaches crater?

_Originally posted by @anthrotype in https://github.com/googlefonts/fontc/pull/2125#discussion_r3991861798_

Contributor guide

No contributing guide indexed for this repository

Research direction

Start with MergeError and trace the master-index swap in fontbe before the error reaches crater. Check how fontbe knows each master’s source path and location, then determine how merge failures can expose that information instead of post-swap indices. Done means the reported master identifies its relevant features.fea source or path.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
compilers
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Active
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.