googlefonts / googlefonts/fontc

[fea-rs] Don't write lookups that are not referenced by a feature

Open
#1,845 0 comments 0 reactions 0 assignees View on GitHub
crater
Dominant language
Rust
Stars
193
Forks
21
Avg merge
1d 17h
Merged PRs (30d)
65

Description

Not sure how this bug has hung around for so long, or if I'm only seeing this in some funny combination of conditions? In any case it is exhibited in at least one font on crater.

```
python3 -m ttx_diff 'https://github.com/notofonts/bhaiksuki?570db5a125#sources/NotoSansBhaiksuki.designspace'
```

Contributor guide

No contributing guide indexed for this repository

Research direction

Start by running the provided ttx_diff command against the NotoSansBhaiksuki.designspace source and inspect which unreferenced lookups are written. Trace the fea-rs lookup-generation path to identify the relevant entry point. Done means the output no longer writes lookups that are not referenced by a feature, while preserving referenced lookups.

Written by the indexing model from the issue text.

Assessment

Tech stack
python, rust
Domain
tooling
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.