googlefonts / googlefonts/fontc

glyphsapp smart components with non-integer setting values can cause off-by-ones

Open
#1,809 0 comments 0 reactions 0 assignees View on GitHub
crater
Dominant language
Rust
Stars
193
Forks
21
Avg merge
1d 20h
Merged PRs (30d)
60

Description

In the glyphs UI when adjusting smart components with the slider it is easy to end up with non-integer values, like:

Image

and when we are actually instantiating these smart components we are sometimes running into some subtle point differences when comparing with fontmake.

There is a minimal test case attached.

[Iansui-build-off-by-ones.glyphs.zip](https://github.com/user-attachments/files/24062909/Iansui-build-off-by-ones.glyphs.zip)

Contributor guide

No contributing guide indexed for this repository

Research direction

Start by reproducing the issue with the attached Iansui-build-off-by-ones.glyphs.zip minimal test case, focusing on smart-component instantiation with non-integer slider values. Compare the resulting points with fontmake; done means the subtle off-by-one differences no longer occur for this case.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
compilers
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.