googlefonts / googlefonts/fontations

[klippa] make the glyph closure signatures match in GSUB and cmap/glyf/COLR?

Open
#988 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Rust
Stars
827
Forks
76
Avg merge
22h 33m
Merged PRs (30d)
75

Description

There is already a trait `GlyphClosure` defined for in GSUB, and I added glyph closure for cmap and glyf tables in #983, should we make the signatures match?
By a quick look, it seems that the glyph closure I added has a input unicodes set, and we compute transititve closure for glyphs in this set only, while the closure in current GSUB table computes all reachable glyphs in the whole table.

Contributor guide

No contributing guide indexed for this repository

Research direction

Start by comparing the existing GSUB `GlyphClosure` trait with the glyph-closure implementations for cmap and glyf added in #983, and check how COLR participates. Determine whether the input-unicode behavior and whole-table reachable-glyph behavior should share one signature, then define the agreed completion criteria and add or update tests for the resulting closure semantics.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
computer-graphics
Issue type
Refactor
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.