googlefonts / googlefonts/fontations

port updated harfbuzz classdef size calculation code

Open
#846 0 comments 0 reactions 0 assignees View on GitHub
bug
Dominant language
Rust
Stars
826
Forks
75
Avg merge
22h 33m
Merged PRs (30d)
75

Description

See https://github.com/harfbuzz/harfbuzz/pull/4616

The previous impl would produce incorrect results in certain instances, although it would take a very pathological input for this to actually result in a packing failure. Our impl is here: https://github.com/googlefonts/fontations/blob/main/write-fonts/src/graph/splitting/pairpos.rs#L385

Contributor guide

No contributing guide indexed for this repository

Research direction

Compare the updated HarfBuzz classdef size calculation in PR 4616 with the implementation at write-fonts/src/graph/splitting/pairpos.rs:385. Trace how the current implementation handles pathological inputs, then confirm the port matches the corrected behavior and no longer permits incorrect packing results.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
computer-graphics
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.