googlefonts / googlefonts/fontations

Our tests don't consistently report what file is missing

Open
#815 0 comments 0 reactions 0 assignees View on GitHub
ergonomics good first issue
Dominant language
Rust
Stars
826
Forks
75
Avg merge
22h 33m
Merged PRs (30d)
75

Description

For example, I'm importing into google3 and getting things like

```shell
---- color::traversal_tests::clipbox_default stdout ----
thread 'color::traversal_tests::clipbox_default' panicked at third_party/rust/skrifa/v0_15/src/color/traversal_tests/mod.rs:306:46:
Unable to open expectations file.: Os { code: 2, kind: NotFound, message: "No such file or directory" }
```

It's sufficient, but saying which file would be more helpful.

Contributor guide

No contributing guide indexed for this repository

Research direction

Start in third_party/rust/skrifa/v0_15/src/color/traversal_tests/mod.rs around line 306 and reproduce color::traversal_tests::clipbox_default. Trace the expectations-file open error; done means the failure reports which file is missing, while the test still passes when that file exists.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
testing-qa
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.