googlefonts / googlefonts/fontations

validation of VariationRegionList axis_count

Open
#744 1 comment 0 reactions 0 assignees View on GitHub
good first issue
Dominant language
Rust
Stars
826
Forks
75
Avg merge
22h 33m
Merged PRs (30d)
75

Description

We should be validating that any set of regions added to the builder have the correct axis count.

I also believe that if we know the number of axes ahead of time there may be possible improvements in the implementation, but I may be confusing axis count and region count.

> If we don't already we should probably validate that the regions match this count since that's possible to check with access to only self?

_Originally posted by @rsheeter in https://github.com/googlefonts/fontations/pull/742#discussion_r1428604171_

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.