googlefonts / googlefonts/fontations

Use binary search to resolve classes from ClassDef

Open
#606 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Rust
Stars
826
Forks
75
Avg merge
22h 33m
Merged PRs (30d)
75

Description

> For shaping at least (and maybe here too?), this will be hot code so it'd be nice to implement with a binary search.

_Originally posted by @dfrg in https://github.com/googlefonts/fontations/pull/597#discussion_r1319480590_

Contributor guide

No contributing guide indexed for this repository

Research direction

Start by locating the ClassDef implementation and the code that resolves classes during shaping. Confirm which lookup path is hot and whether the issue applies there; done means the applicable ClassDef resolution uses binary search and existing behavior remains unchanged.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
computer-graphics
Issue type
Refactor
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.