googlefonts / googlefonts/fontations

TTCHeader::compute_version should be removed or fixed

Open
#1,945 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Rust
Stars
826
Forks
75
Avg merge
22h 33m
Merged PRs (30d)
75

Description

either we don't compile this structure, in which case we don't need this annotation or to otherwise be generating compile code for this type, or we _do_ want to compile this structure, in which case this fn should be implemented.

> huh this panic should've been removed ages ago, even if we _aren't_ compiling this? will open an issue..
>

_Originally posted by @cmyr in [#1942](https://github.com/googlefonts/fontations/pull/1942/changes#r3462490330)_

Contributor guide

No contributing guide indexed for this repository

Research direction

Start by locating the TTCHeader::compute_version entry point and review the context from pull request #1942. Determine whether TTCHeader is compiled; done means either removing the unnecessary annotation and generated code or implementing the function, with the panic no longer remaining.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
backend
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Quiet
Clarity
Needs clarification
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.