googlefonts / googlefonts/fb-variable-spacing

Performance of code to keep components in place

Open
#4 0 comments 0 reactions 1 assignee Claimed by @gferreira View on GitHub
Dominant language
Python
Stars
2
Forks
1
PR merge metrics
No merged PRs in 30d

Description

the code used to keep components in place after changes to the left margin of base glyphs has been rewritten using the algorithm described by @dberlow (thanks!).

the new version produces 100% correct results in all tests made so far, while the previous version had a bug which affected glyphs with multiple versions of the same component.

however, the new version is a lot slower.

TO DO:

- look into ways to optimize the component alignment code in functions `loadSpacingFromLib` and `smartSetMargins`

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.