googlefonts / googlefonts/diffenator2

Images should be padded to maximise dimensions, not cropped

Open
#52 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Python
Stars
68
Forks
9
PR merge metrics
No merged PRs in 30d

Description

Currently we compare two word-images by first finding the minimum dimensions between them, then cropping. Imagine a mark glyph which was previously spacing (had advance width) but has become non-spacing (zero-width). Both images get cropped to zero and then compare equally. Oops.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.