googlefonts / googlefonts/diffenator2

Downloading a GitHub release assumes the first asset is correct

Open
#134 1 comment 0 reactions 1 assignee Claimed by @m4rc1e View on GitHub
Dominant language
Python
Stars
68
Forks
9
PR merge metrics
No merged PRs in 30d

Description

https://github.com/googlefonts/diffenator2/blob/7986b847c22a7591b3d307d252f053ff99aa90ab/src/diffenator2/utils.py#L57-L73

(line 72, the `[0]`)

In a project I'm working on, this downloads the wrong release artifact, resulting in an error later on. When using the GitHub Action, there's currently no way to work around this

A couple of suggestions:
1. Some kind of filtering support (both in diffenator2 and its GitHub action) or other means of selection
2. For the GitHub action, log the name of the file being downloaded so this is easier to debug :)

I don't need an urgent fix, just thought it was worth having on the issue tracker!

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.