googleapis / googleapis/synthtool
Python: samples noxfile.py should respect INSTALL_LIBRARY_FROM_SOURCE=False in noxfile_config
Open
lang: python
samples
type: feature request
- Dominant language
- Python
- Stars
- 108
- Forks
- 102
- Avg merge
- 1h 23m
- Merged PRs (30d)
- 1
Description
Samples in libraries always install the library from source on presubmits.
`INSTALL_LIBRARY_FROM_SOURCE` set to `False` in the `noxfile_config.py` should be respected by the samples noxfile so some samples can be pinned to older library versions.
This line should be modified to check `TEST_CONFIG` as well
https://github.com/googleapis/synthtool/blob/33366574ffb9e11737b3547eb6f020ecae0536e8/synthtool/gcp/templates/python_samples/noxfile.py.j2#L95
CC @kolea2
Contributor guide
Assessment
This issue has not been assessed yet.