googleapis / googleapis/synthtool

Post-processor container relies on external dependency

Open
#1,415 3 comments 0 reactions 0 assignees View on GitHub
bot: owl-bot lang: php priority: p3 type: bug
Dominant language
Python
Stars
108
Forks
102
Avg merge
1h 23m
Merged PRs (30d)
1

Description

## Problem

The PHP post-processor container has a dependency on an external dependency installed from npm:

```
Step googleapis/repo-automation-bots#1: - TLSSocket
Step googleapis/repo-automation-bots#1: - TLSSocket
Step googleapis/repo-automation-bots#1: - Socket
Step googleapis/repo-automation-bots#1: - Socket
Step googleapis/repo-automation-bots#1: - Socket
Step googleapis/repo-automation-bots#1: Active handles:
Step googleapis/repo-automation-bots#1: Process stalled
Step googleapis/repo-automation-bots#1: error An unexpected error occurred: "https://registry.npmjs.org/prettier/-/prettier-2.2.1.tgz: unexpected end of file".
Step googleapis/repo-automation-bots#1: (warning package-lock.json found. Your project contains lock files generated by tools other than Yarn. It is advised not to mix package managers in order to avoid resolution inconsistencies caused by unsynchronized lock files. To clear this warning, remove
```

This makes it susceptible to intermittent network issues on the upstream registry. It also makes it possible that we have a nested dependency break, if we're not using a `package-lock.json` during installation.

## Possible solution

Install `prettier` into container when building.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.