googleapis / googleapis/storage-testbench

Add checks for invocation-id to testbench

Open
#486 0 comments 3 reactions 1 assignee Claimed by @tritone View on GitHub
priority: p3 type: feature request
Dominant language
Python
Stars
24
Forks
38
Avg merge
1d 15h
Merged PRs (30d)
1

Description

@saranshdhingra suggested that it would be helpful to add an option to check correctness of the x-goog-api-client header in the retry test support in the testbench.

This might include the following:
1. Check that gccl-invocation-id is the same for all retries of a given request
2. [if applicable] Check that gccl-attempt-count starts at 1 and gets incremented for each retry.

We could also add a check for `x-goog-gcs-idempotency-token` when implemented.

This check could be enabled by a data field or query param to the retry_test POST endpoint.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.