googleapis / googleapis/release-please

Changelog shows peer dependency updated regardless of "updatePeerDependencies" setting.

Open
#2,610 1 comment 0 reactions 1 assignee Claimed by @chingor13 View on GitHub
priority: p3 type: bug
Dominant language
TypeScript
Stars
7.5k
Forks
588
Avg merge
12h 16m
Merged PRs (30d)
7

Description

Thanks for stopping by to let us know something could be better!

Please provide the following details.

#### Environment details

- OS: Linux
- Node.js version: 20.19.5
- npm version: 10.8.2
- release-please version: 17.1.3

#### Steps to reproduce

1. Use the node workspace plugin with at least 2 packages. For these instructions package A and package B.
2. Set the "updatePeerDependencies" to false for the node-workspace plugin in the release-please-config.json.
3. Package B has a peer and dev dependency on package A.
4. Make a change to package A with a commit that results in a releasable unit.
5. The package.json of B will have its peer dependency updated.

Example commit where this happened: https://github.com/launchdarkly/js-core/pull/967/commits/8fec63439a9910ab7a9402245aba8dc5170fada8

Specific files:
https://github.com/launchdarkly/js-core/pull/967/commits/8fec63439a9910ab7a9402245aba8dc5170fada8#diff-0d50a1ec57fb7a9069bc636c9858e3b3f38ba409158cbed9ac05f82c3dfe5a6a
https://github.com/launchdarkly/js-core/pull/967/commits/8fec63439a9910ab7a9402245aba8dc5170fada8#diff-6424ca68de02b787957be3b9d33ab66b41ad2f4509815c2a0f6890a875122e75

This issue is related to #2269 where the peer dependency was fixed to honor the setting, but the changelog was not updated.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.