googleapis / googleapis/release-please

Mono repo release skipped when only the root project is updated

Open
#2,598 0 comments 0 reactions 1 assignee Claimed by @chingor13 View on GitHub
priority: p3 type: bug
Dominant language
TypeScript
Stars
7.5k
Forks
588
Avg merge
12h 16m
Merged PRs (30d)
7

Description

Thanks for stopping by to let us know something could be better!

Please provide the following details.

#### Environment details

- OS: ubuntu
- Node.js version: v22.19.0
- npm version: 10.9.3
- `release-please` version: v17.1.2

#### Steps to reproduce

I have a monorepo setup, `release-please-config.json`
```
"packages": {
"packages/bla": {},
".": {
"include-component-in-tag": false,
}
},
```

When I change package `bla`, release-please correctly tags bla and the root library. However, if I only change the root library it doesn't.

Having a look at the code, I can see `buildRelease` is skipped here: https://github.com/googleapis/release-please/blob/2ec56e7c9b3fd36b2c7cabfbad9eb949197224ba/src/strategies/base.ts#L648

Adding a check like `&& component !== ''` seems to work for me https://github.com/googleapis/release-please/blob/2ec56e7c9b3fd36b2c7cabfbad9eb949197224ba/src/strategies/base.ts#L645

However, it breaks this test which I don't understand. https://github.com/googleapis/release-please/blob/2ec56e7c9b3fd36b2c7cabfbad9eb949197224ba/test/manifest.ts#L5604

Making sure to follow these steps will guarantee the quickest resolution possible.

Thanks!

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.