googleapis / googleapis/release-please

Missing `component` field in config schema - python monorepo

Open
#2,573 0 comments 0 reactions 1 assignee Claimed by @chingor13 View on GitHub
priority: p3 type: bug
Dominant language
TypeScript
Stars
7.5k
Forks
588
Avg merge
12h 16m
Merged PRs (30d)
7

Description

Hello, don't know if this is an error on my part but I have a monorepo with a Python package. I don't have a setup.py or a setup.cfg just a pyproject.toml. I notice it doesn't seem to pull the component name into PR titles:
`chore(component-name): v1.0.0`. I fixed it by adding the component in the config. The Node packages seem to pull directly from the package.json. Wondering if this is intended? I noticed `component` isn't in the schema too, happy to open a pr for this if unintentionally left out. Thanks :)

#### Environment details

- OS:
- Node.js version: v22.14.0
- npm version: 11.4.2
- `release-please` version: v4

#### Steps to reproduce
Create a release-please-config.json in a monorepo like this:
```json
{
"packages": {
"lorem": {
"path": "lorem",
"release-type": "python"
}
}
}
```
Run release-please manifest-pr or release-please github-release.

Observe that the generated pull request has a generic title like:

chore: release 1.2.3
Add "component": "lorem" manually to the config:

```json
{
"packages": {
"lorem": {
"path": "lorem",
"release-type": "python",
"component": "lorem"
}
}
}
```

Delete previous pr and run the action again and the pull request title should be:

chore(lorem): release 1.2.3

---

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.