googleapis / googleapis/release-please
release-please LinkedVersions not bumping after CargoWorkspace
- Dominant language
- TypeScript
- Stars
- 7.5k
- Forks
- 588
- Avg merge
- 12h 16m
- Merged PRs (30d)
- 7
Description
Hi,
I've implemented release-please in my monorepo containing rust and python packages. I have 3 rust libraries (`hello-rust1/2/3`) and 3 corresponding python libraries (`hello-python1/2/3`) where they are linked together, so when `hello-rust1` gets bumped then `LinkedVersions` plugin should bump `hello-python1` too (same for `hello-rust2/hello-python2` and `hello-rust3/hello-python3`)
`hello-rust1` and `hello-rust2` both depend on `hello-rust3`, and cargo-workspace plugin handles this as expected.
The problem is when there is a commit to `hello-rust3` but no commit to `hello-rust1/2` or `hello-python1/2`. What I see happening is `cargo-workspace` forces version bump on `hello-rust1` and `hello-rust2`, but when the `LinkedVersions` plugin runs i just see `✔ found 0 linked-versions candidates` so `hello-python1` and `hello-python2` are not bumped along with `hello-rust-1` and `hello-rust3`
Below is my `release-please-config.json`
```
{
"include-component-in-tag": true,
"include-v-in-tag": true,
"tag-separator": "@",
"always-link-local": true,
"packages": {
"packages/hello-rust1": {
"release-type": "rust",
"component": "hello-rust1"
},
"packages/hello-rust2": {
"release-type": "rust",
"component": "hello-rust2"
},
"packages/hello-rust3": {
"release-type": "rust",
"component": "hello-rust3"
},
"packages/hello-python1": {
"release-type": "python",
"component": "hello-python1"
},
"packages/hello-python2": {
"release-type": "python",
"component": "hello-python2"
},
"packages/hello-python3": {
"release-type": "python",
"component": "hello-python3"
}
},
"plugins": [
{
"type": "cargo-workspace",
"considerAllArtifacts": true,
"merge": false,
"updateAllPackages": false,
"updatePeerDependencies": true
},
{
"type": "linked-versions",
"groupName": "group1",
"components": [
"hello-rust1",
"hello-python1"
]
},
{
"type": "linked-versions",
"groupName": "group2",
"components": [
"hello-rust2",
"hello-python2"
]
},
{
"type": "linked-versions",
"groupName": "group3",
"components": [
"hello-rust3",
"hello-python3"
]
}
],
"$schema": "https://raw.githubusercontent.com/googleapis/release-please/main/schemas/config.json"
}
```
Contributor guide
Assessment
This issue has not been assessed yet.