googleapis / googleapis/release-please
Updating versions of Maven multi-module project results in invalid setup
- Dominant language
- TypeScript
- Stars
- 7.5k
- Forks
- 588
- Avg merge
- 12h 16m
- Merged PRs (30d)
- 7
Description
#### Environment details
- OS: Linux
- Node.js version: 20
- `release-please` version: 16.18.0
#### Steps to reproduce
1. Have a Maven multi-modul project where there are two sub modules.
a. The modules have the parent project as Maven parent
b. One of the module has the other as a dependency.
2. Make sure that the (parent) project builds correctly.
3. Create a release PR with Release Please.
4. Pull PR's content and build it.
#### Expected behaviour
Project should build with new version number.
#### Current behaviour
Build fails with `Non-resolvable parent POM` error.
After checking it can be seen that parent versions are not updated.
Fix parent versions and triggering build.
It fails again with `Non-resolvable dependency version`
After checking it can be seen that sibling dependency version is not updated.
#### Suggestion
As Maven has a well established and maintained [plugin](https://www.mojohaus.org/versions/versions-maven-plugin/index.html) it could be beneficial to rely on that regarding version updates of Maven based projects.
Thanks!
Contributor guide
Assessment
This issue has not been assessed yet.