googleapis / googleapis/release-please

Simple strategy does not allow v prefix in version files

Open
#2,536 0 comments 0 reactions 1 assignee Claimed by @chingor13 View on GitHub
priority: p3 type: feature request
Dominant language
TypeScript
Stars
7.5k
Forks
588
Avg merge
12h 16m
Merged PRs (30d)
7

Description

The `simple` strategy just overwrites the contents of `version-file` with `X.Y.Z`. This is a problem for my usecase because I need this file to contain `v.X.Y.Z`.

I can't use the `extra-files`method discussed in some other issues because I rely on this file only containing the version string, putting the `x-release-please-version` flag in my version.txt is going to break many places where i `cat` this file and expect only the version in the content.

I'm proposing that if the version file contains a version already, then we just update the version in place like we do for `x-release-please-version`, rather than overwrite the file. I've implemented this solution in https://github.com/googleapis/release-please/pull/2537

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.