googleapis / googleapis/release-please

release upon dependency changes from renovate-bot

Open
#2,526 3 comments 2 reactions 1 assignee Claimed by @chingor13 View on GitHub
priority: p3 type: bug
Dominant language
TypeScript
Stars
7.5k
Forks
588
Avg merge
12h 16m
Merged PRs (30d)
7

Description

The `release-please` README [says](https://github.com/googleapis/release-please) that it will only create a release if there are "releaseable units", i.e. commits with one of the following prefixes: `feat`, `fix`, or `deps`. It specifically states `A "chore" or "build" commit is not a releasable unit.`

The commits generated by renovate-bot are prefixed by `chore(deps)`, so **they are excluded from the release criteria**. However, it seems that the intent of release-please is to re-release when there are dependency changes, correct?

In that case, it seems release-please should be made to accommodate renovate-bot commit messages.

If we explicitly want to exclude renovate-bot changes from triggering release-please (eg because of their frequency?), let's say so explicitly in the README and provide a rationale.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.