googleapis / googleapis/release-please

plugin cargo-workspace missing some file update

Open
#2,517 0 comments 0 reactions 1 assignee Claimed by @chingor13 View on GitHub
priority: p3 type: bug
Dominant language
TypeScript
Stars
7.5k
Forks
588
Avg merge
12h 16m
Merged PRs (30d)
7

Description

#### Environment details

- OS: Ubuntu 24.04.2
- Node.js version: 20.19.0
- npm version: 10.8.2
- `release-please` version: 16.18.0

> GitHub action with `googleapis/release-please-action@v4`

#### Steps to reproduce

1. create a cargo workspace
2. make this repo as one version `{".": x.y.z}` in `.release-please-manifest.json`

The plugin cargo-workspace seems will skip `cargo.lock` update (missing members version update) and `.github/.release-please-manifest.json`

```
# manifest.json
...
"plugins": ["cargo-workspace"],
...
```
If you add "plugins": ["cargo-workspace"], to the config.json , release-please will skip the Cargo.lock's member updates and manifest.json's version updates.

you can see entire repo construct in https://github.com/toyfield/cargo-workspace-release-please

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.