googleapis / googleapis/release-please

component-no-space not allowed in json schema

Open
#2,471 1 comment 2 reactions 1 assignee Claimed by @chingor13 View on GitHub
help wanted priority: p3 type: bug
Dominant language
TypeScript
Stars
7.5k
Forks
588
Avg merge
12h 16m
Merged PRs (30d)
7

Description

#### Environment details

- OS: `Ubuntu 22.04.5 LTS x86_64`
- Node.js version: `v22.11.0`
- npm version: `10.9.0`
- `release-please` version: `v16.15.0`

#### Steps to reproduce

Code available at https://github.com/landlockedboat/release-please-test

The configuration we are using is as follows:

```json
{
"$schema": "https://raw.githubusercontent.com/googleapis/release-please/main/schemas/config.json",
"include-component-in-tag": true,
"tag-separator": "@",
"pull-request-title-pattern": "chore(${component}): release ${version}",
"pull-request-header": ":rocket: New Release",
"separate-pull-requests": true,
"component-no-space" : true,
"packages": {
"api": {
"release-type": "maven",
"skip-snapshot": true,
"package-name": "api"
},
"ui": {
"release-type": "node"
},
"chart": {
"release-type": "helm"
}
}
}
```

vscode warns us that `Property component-no-space is not allowed.`

We suspect the issue is because in the [schema](https://raw.githubusercontent.com/googleapis/release-please/main/schemas/config.json):

```json
"properties": {
"$schema": true,
"packages": true,
[...],
"component-no-space": false
}
```

`component-no-space` is set to false, which we suspect is making release-please mark it as invalid.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.