googleapis / googleapis/release-please

Monorepo: Avoid creating empty PR

Open
#2,384 2 comments 6 reactions 1 assignee Claimed by @chingor13 View on GitHub
priority: p3 type: feature request
Dominant language
TypeScript
Stars
7.5k
Forks
588
Avg merge
12h 16m
Merged PRs (30d)
7

Description

**Is your feature request related to a problem? Please describe.**
Kinda! We have a monorepo and it's creating a PR for the root (I guess) named `chore: release main` with 0 files on it.

I have the following release-please-config.json

```json
{
"include-component-in-tag": true,
"include-v-in-tag": false,
"tag-separator": "@",
"separate-pull-requests": true,
"pull-request-footer": "Al mergear esto va a deployar a PROD!",
"packages": {
"apps/web1": {
"component": "@app/web1",
"release-type": "node"
},
"apps/web2": {
"component": "@app/web2",
"release-type": "node"
},
"packages/sdk-js": {
"component": "@pkg/sdk",
"release-type": "node"
}
},
"plugins": [
{
"type": "node-workspace",
"updatePeerDependencies": true
}
],
"$schema": "https://raw.githubusercontent.com/googleapis/release-please/main/schemas/config.json"
}
```

I don't understand the reason that it's creating that empty PR if there is no "." packages in `release-please-config.json` file.

**A clear and concise description of what you want to happen.**

If there is no "." entry declared, it should create a PR for the root package.json.

**Add any other context or screenshots about the feature request here.**
![image](https://github.com/user-attachments/assets/5fe6ce21-2357-430a-b2a5-19c7ddc33945)

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.