googleapis / googleapis/release-please

Expo strategy extend to use app.config.js(ts) file in addition to app.json

Open
#2,264 1 comment 0 reactions 1 assignee Claimed by @chingor13 View on GitHub
priority: p3 type: feature request
Dominant language
TypeScript
Stars
7.5k
Forks
588
Avg merge
12h 16m
Merged PRs (30d)
7

Description

Latest version of Expo allows to use dynamic config file such as `app.config.js(ts)` instead of `app.json`. Here is documentation link https://docs.expo.dev/versions/latest/config/app/

In essence this is superset of `app.json` and has very similar structure for versioning e.g.

```js
.....
export default {
expo: {
name: NAME,
slug: SLUG,
privacy: "unlisted",
platforms: ["ios"],
version: "1.0.0", // x-release-please-version
orientation: "portrait",
scheme: SCHEME,
icon: "./assets/icon.png",
updates: {
fallbackToCacheTimeout: 30000,
url: URL
},
assetBundlePatterns: ["**/*"],
ios: {
bundleIdentifier: IDENTIFIER
supportsTablet: true,
buildNumber: "1.0.0", // x-release-please-version
runtimeVersion: {
policy: "sdkVersion",
},
},
description: DESCRIPTION
extra: {
eas: {
projectId: PROJECT_ID,
},
},
owner: "OWNER",
},
};

```

**Is your feature request related to a problem? Please describe.**
When using dynamic config file `app.config.js(ts)` version is not being updated, unless tagging lines with version using `x-release-please-version` and adding `app.config.js(ts)` as an extra file.

**Describe the solution you'd like**
No need to use extra configuration with extra file.

**Describe alternatives you've considered**
Adding extra file with target lines works just fine.

**Additional context**
If you are using release please github action v4 and it's not picking up extra file, consider this undocumented [behavior](https://github.com/google-github-actions/release-please-action/issues/941#issuecomment-2036412965).

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.