googleapis / googleapis/release-please

yaml updater removes quotes from strings

Open
#2,195 2 comments 4 reactions 1 assignee Claimed by @chingor13 View on GitHub
priority: p3 type: question
Dominant language
TypeScript
Stars
7.5k
Forks
588
Avg merge
12h 16m
Merged PRs (30d)
7

Description

Thanks for stopping by to ask us a question! Please make sure to include:
- What you're trying to do
- What code you've already tried
- Any error messages you're getting

Hello,

I'm using release-please through the Github Action. But the issue I'm having comes from this package I think.

I'm using the yaml updater to update a version in a yaml file. But release please modifies more than just the version. It removes all the single quotes around strings and converts the text to `>-` syntax.

The issue is probably coming from `js-yaml` package. But I could not reproduce it manually. I'm using the latest release please GA which in turn should use `js-yaml` version 4 where there should be quotes around strings all the time. I believe only in version 3 there were no quotes.

Does anyone have any idea?

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.