googleapis / googleapis/release-please

Support overriding unparsable commits

Open
#2,174 2 comments 1 reaction 1 assignee Claimed by @chingor13 View on GitHub
priority: p3 type: feature request
Dominant language
TypeScript
Stars
7.5k
Forks
588
Avg merge
12h 16m
Merged PRs (30d)
7

Description

**Is your feature request related to a problem? Please describe.**

I recently adopted conventional commits and release-please in a GitHub repository. Before this, we handled releases manually.

Since the last release, there are a few commits on the default branch (~50) that don't follow the conventional commits spec that I need to include in the next release (the first one that release-please will manage).

If I'm reading the code correctly, [this scenario is not supported](https://github.com/googleapis/release-please/blob/611db3d5628d1ff4cd7c40259894daf0c13f8e17/src/commit.ts#L377-401). In fact, I get a `commit could not be parsed....` error message. So release-please doesn't take into account the eventual `BEGIN_COMMIT_OVERRIDE` in the PR body.

**Describe the solution you'd like**

If the commit body contains a PR number (`#...`), release-please should fall back to reading the PR body even if it wasn't able to completely parse the message.

**Describe alternatives you've considered**

Rewriting history would work, but I'd prefer avoiding that.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.