googleapis / googleapis/release-please

Not updating `.release-please-manifest.json`

Open
#2,172 17 comments 7 reactions 1 assignee Claimed by @chingor13 View on GitHub
priority: p3 type: bug
Dominant language
TypeScript
Stars
7.5k
Forks
588
Avg merge
12h 16m
Merged PRs (30d)
7

Description

We use `release-please` to create releases for the Puppeteer project. The current structure is a mono repo so we use a [configuration file ](https://github.com/puppeteer/puppeteer/blob/main/release-please-config.json) to express this.
This works well for the 3 packages that depend on each other `puppeteer`, `puppeteer-core`, and `@puppeteer/browsers`.
But for the last one `@puppeteer/ng-schematics` we are seeing issue that the release does not update [`.release-please-manifest.json`](https://github.com/puppeteer/puppeteer/blob/main/.release-please-manifest.json).

This can be observed on the latest PR - https://github.com/puppeteer/puppeteer/pull/11543.
If we do merge this PR without updating the manifest manually `release-please` will open a new one as the version differs with the manifest file. Observed:
Initial - https://github.com/puppeteer/puppeteer/pull/11496
A second one - https://github.com/puppeteer/puppeteer/pull/11508

The issue is not consistent. It doesn't fail all the time as you can see from https://github.com/puppeteer/puppeteer/pull/11488

#### Environment details

- GitHub App

#### Steps to reproduce

1. Have not reproduced locally, but happy to follow up if instruction are provided.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.