googleapis / googleapis/release-please

Jira integration and release-please results in "No user facing commits found"

Open
#2,047 3 comments 0 reactions 1 assignee Claimed by @chingor13 View on GitHub
priority: p3 type: feature request
Dominant language
TypeScript
Stars
7.5k
Forks
588
Avg merge
12h 16m
Merged PRs (30d)
7

Description

No user-facing commits are found when we title our pull requests with a reference to Jira even when the notes of the squashed merge contain conventional commits. Our policy requires us to add the jira issue identifier to the title of the pull request and this will link the GitHub pull request and jira automatically.

Example pattern: "JIRA-1234: Adds a new feature that does interesting things"

Within the commits in the pull request, we may have additional conventional commits defined.

```text
commit 1234567890abcdef
Author: Me
Date: ...

JIRA-1234: Adds a new feature that does interesting things

* fix: fixes a bug with the ...

* feat: Adds the new XYZ feature
```

**Describe the solution you'd like**

With some additional logging added to release-please, the CLI output shows that the merged pull requests are found and that the notes, like the example above, are seen, but the result remains that release-please reports "No user facing commits since ..."
I believe this may be because the conventional commit filter removes the candidate based on the title of the pull request. However, each of the pull requests should be a likely candidate for the changelog and a release.

**Describe alternatives you've considered**

* Configuration settings to allow the pull request title to be used
* Mechanism to enhance the processing of the squashed merge footer

I have noticed that if the title includes a conventional commit tag after the jira identifier, that release-please will sometimes , but not always, generate a pull request. Example: `JIRA-1234: feat: Adds an awesome new feature`

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.