googleapis / googleapis/release-please

Consider inserting fillers between lines in manifest files

Open
#1,502 2 comments 20 reactions 0 assignees View on GitHub
priority: p3 type: feature request
Dominant language
TypeScript
Stars
7.5k
Forks
588
Avg merge
12h 16m
Merged PRs (30d)
7

Description

We have a large monorepo that uses manifests. The manifest file is of course a JSON file that includes a line for each package, that is updated whenever a new version of the package is released. We frequently release multiple packages in succession (in separate PRs). If two of those packages are adjacent in the manifest file, this causes git conflicts since the PRs independently try to modify adjacent lines in the same file.

Our current workaround has been to insert filler lines in our [manifest file](https://github.com/googleapis/google-cloud-ruby/blob/main/.release-please-manifest.json), in the form of a "fake" package following each real package, to separate out the real packages and ensure that no two occupy adjacent lines in the file. This seems to be working for us for now, but maybe we can consider building a solution into the tool itself.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.