googleapis / googleapis/release-please-action

Fail job if PR isn't created

Open
#970 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
TypeScript
Stars
2.5k
Forks
327
PR merge metrics
No merged PRs in 30d

Description

### TL;DR

In some circumstances, the PR can fail to be created.

It would be nice if the Job failed

Note: We have many repos, and use the merging of a release candidate PR to deploy. If we don't get the PR and CI passes we are liable to not realise

### Detailed design

This was my not-great™ fix
```diff
jobs:
create-release-pr:
runs-on: ubuntu-latest
steps:
- uses: google-github-actions/release-please-action@v3 # v3 as we are still on node 18 in this repo
with:
release-type: node
package-name: release-please-action
prerelease: false

+ - name: Check for Malformed Commit Messages
+ run: |
+ if echo "${{ steps.release-please.outputs.logs }}" | grep -q "commit could not be parsed"; then
+ echo "Malformed commit message found"
+ exit 1
+ fi
```

### Additional information

_No response_

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.