googleapis / googleapis/release-please-action

prs_created is false when a release PR is updated

Open
#963 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
TypeScript
Stars
2.5k
Forks
327
PR merge metrics
No merged PRs in 30d

Description

### TL;DR

![image](https://github.com/google-github-actions/release-please-action/assets/61225/1d748436-f21b-4654-9cdf-0cccb63c7005)

says it will set prs_created to true when it updates a pr.

but it doesn't.

### Expected behavior

if a release pr is updated, set `prs_created` to `true`.

### Observed behavior

if a release pr is updated, set `prs_created` to `false`.

### Action YAML

```yaml
name: Release

on:
push:
branches:
- master

env:
HUSKY: 0 # https://typicode.github.io/husky/how-to.html#ci-server-and-docker

concurrency:
group: ${{ github.workflow }}-${{ github.ref }}

# Needed for nx-set-shas within nx-cloud-main.yml, when run on the master branch
permissions:
actions: read
contents: write
deployments: write
pull-requests: write
id-token: write

jobs:
Process:
runs-on: ubuntu-latest
outputs:
releases_created: ${{ steps.release-please.outputs.releases_created }}
steps:
- uses: google-github-actions/release-please-action@v4
id: release-please
with:
token: ${{secrets.MY_MAGICAL_TOKEN}}
- name: Print Release Data
run: |
echo 'Release Data:'

echo '''
${{ toJSON(steps.release-please.outputs) }}
'''

Deploy:
needs: Process
runs-on: ubuntu-latest
steps:
- name: Checkout
uses: actions/checkout@v3
with:
fetch-depth: 0

- uses: asdf-vm/actions/install@f4acd427436df623426c29f7e3e9ea715be28396

- name: Yarn
uses: ./.github/actions/setup-yarn

- name: Configure Publishing
uses: ./.github/actions/setup-npm-publish
with:
NpmRegistryUrl: https://registry.npmjs.org/
NpmRcFile: .npmrc

- uses: nrwl/nx-set-shas@v3

- uses: mansagroup/nrwl-nx-action@v3.2.2
if: ${{ needs.Process.outputs.releases_created == 'true' && needs.Process.outputs.prs_created != 'true' }}
with:
targets: release
args: '--configuration=production'

- uses: mansagroup/nrwl-nx-action@v3.2.2
if: ${{ needs.Process.outputs.releases_created != 'true' && needs.Process.outputs.prs_created == 'true' }}
with:
targets: release
args: '--configuration=development'
```

### Log output

```text
Run echo 'Release Data:'
Release Data:

{
"releases_created": "false",
"paths_released": "[]",
"prs_created": "false"
}
```
```

### Additional information

_No response_

Contributor guide

Open the contributing guide

Research direction

Start with the release-please-action@v4 workflow entry point and trace how the action sets the prs_created output when an existing release PR is updated. Reproduce the workflow using the provided YAML and inspect the emitted output values. Done means prs_created is true for an updated release PR, with the existing release behavior preserved.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
ci-cd, release
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.